Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Merging of variables #128

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Fix Merging of variables #128

merged 6 commits into from
Aug 15, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Aug 15, 2024 •
edited
Loading

Description

  • Bug when we try to merge granules in collection that have day and night granules. Some granules would have extra variables in it, i believe night had more than day.
  • When merging not all variables might be included really depends on the list of granules and which is first.
  • Add harmony deployment step to github actions

Example:

  • if day granule was first on the list then not all the variables were included
  • if night granule was first on the list then all variables were included

Overview of work done

  • Fixed it so that if theres a difference in the variables between granules then update the var info list

Overview of verification done

  • tested local concatenation of MODIS_T-JPL-L2P-v2019.0

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 changed the title update code pylint and flake8 Fix Merging of variables Aug 15, 2024
frankinspace
frankinspace reviewed Aug 15, 2024
View reviewed changes
deployment/harmony_deploy.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider turning this into a github action

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear why it has to be a Python script specifically. Doesn't seem like anything that can't be done within bash + curl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea it could be i just wrote it in python

joshgarde
joshgarde approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@joshgarde joshgarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good; always beautiful to see a bugfix where code can be removed/rewritten to be more elegant

@sliu008 sliu008 merged commit 58aba18 into develop Aug 15, 2024
2 checks passed
@sliu008 sliu008 deleted the feature/bugfix_merge_variables branch August 15, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankinspace frankinspace frankinspace left review comments

@joshgarde joshgarde joshgarde approved these changes

@jamesfwood jamesfwood Awaiting requested review from jamesfwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sliu008 @joshgarde @frankinspace